Skip to content
got 34 comments on my first big PR and i kinda want to crawl into a hole
question1 min read278 viewsSep 23, 2026

got 34 comments on my first big PR and i kinda want to crawl into a hole

Kevin Tran@kevtran_dev

September 23, 2026 · 1 min read

#2 in Hello World Again

278 views6 comments

so i finally got my first real feature (a filters panel for our admin dashboard) and opened the PR today. 34 comments. thirty four. some are tiny like naming, some are "this should be a custom hook", and one just says "lets talk about this" which sounds terrifying

my senior is nice and none of the comments are mean. but i kind of feel like a fraud and now everyone can see it. in the kitchen if you messed up the chef yelled at you and 5 minutes later it was over lol, this feels different because its all written down forever

how do you all deal with this? do i reply to every single comment? fix everything in one commit or many? and is 34 a normal number or am i cooked

Accepted answer

Grace Wanjiru#1 in Hello World Again4 likes

You are not cooked. 34 comments on a first big PR is completely normal, honestly it means your senior cares enough to teach you. What I tell my mentees: 1. Read everything once, then sort into three piles: must fix, nits, and questions or discussions. 2. Reply to every comment, even just "done" or "good point, fixed". It shows you read it. 3. If you disagree, say so politely with your reason. Seniors are wrong sometimes too. 4. For "lets talk about this", ask for 15 minutes on a call. It is usually less scary in person. 5. Next time, smaller PRs. 34 comments is often a sign the PR was big, not that you are bad.

View in the thread

#career#code-review#learning

Written by

Kevin Tran

used to run a pho kitchen, now junior frontend dev in houston (8 months in!!). learning react, typescript and how to not panic in standups. ask me about broth

View profile

Get the best of #hello_world_again weekly

One email each Monday with the most useful posts. No spam; unsubscribe in one click.

Comments

6

Sign in to join the conversation.

Sign in to comment

Accepted answer

Grace Wanjiru@grace_wanjiru#1 in Hello World Again
You are not cooked. 34 comments on a first big PR is completely normal, honestly it means your senior cares enough to teach you. What I tell my mentees: 1. Read everything once, then sort into three piles: must fix, nits, and questions or discussions. 2. Reply to every comment, even just "done" or "good point, fixed". It shows you read it. 3. If you disagree, say so politely with your reason. Seniors are wrong sometimes too. 4. For "lets talk about this", ask for 15 minutes on a call. It is usually less scary in person. 5. Next time, smaller PRs. 34 comments is often a sign the PR was big, not that you are bad.
4 net votes
Kevin Tran@kevtran_dev#2 in Hello World Again
this is so helpful. sorting into piles is literally how we did prep lists in the kitchen haha. ok i can do this
0 net votes
Rachel Kim@rachelkim#5 in Hello World Again
From the other side: I review a lot of specs and PRs. When I leave many comments it is because the work is worth investing in. Nobody writes 34 comments on something they plan to throw away.
1 net votes
Tomasz Kowalski@tomasz_k#4 in Hello World Again
34 is nothing. My first code review in 2008 was printed on paper and returned with red pen. Whole page was red. Now you have dark mode, you will survive.
3 net votes
Kevin Tran@kevtran_dev#2 in Hello World Again
update: replied to everything, had the "lets talk" call, it was just about moving some logic into a hook so it can be tested. PR merged!! thanks everyone
0 net votes
Grace Wanjiru@grace_wanjiru#1 in Hello World Again
Proud of you Kevin! Next PR, half the size.
2 net votes